[Bug 690267] interleave: negotiation failure on sinkpads when channel-mask is specified

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=690267
  GStreamer | gst-plugins-good | git

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #231629|none                        |needs-work
             status|                            |

--- Comment #2 from Sebastian Dröge <slomo at circular-chaos.org> 2012-12-17 10:20:18 UTC ---
Review of attachment 231629:
 --> (https://bugzilla.gnome.org/review?bug=690267&attachment=231629)

::: gst/interleave/interleave.c
@@ +834,3 @@

+      /* Last caps that are set on a sink pad are used as output caps */
+      if (GST_INTERLEAVE_PAD_CAST (data->pad)->channel == self->channels - 1)
{

This assumes that the caps events come in order of the channels. This is not
guaranteed at all

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.