[Bug 690267] interleave: negotiation failure on sinkpads when channel-mask is specified

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=690267
  GStreamer | gst-plugins-good | git

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #231709|none                        |needs-work
             status|                            |

--- Comment #4 from Sebastian Dröge <slomo at circular-chaos.org> 2012-12-17 11:16:25 UTC ---
Review of attachment 231709:
 --> (https://bugzilla.gnome.org/review?bug=690267&attachment=231709)

::: gst/interleave/interleave.c
@@ +836,3 @@
+      g_atomic_int_add (&self->configured_sinkpads_counter, 1);
+      /* Last caps that are set on a sink pad are used as output caps */
+      if (self->configured_sinkpads_counter == self->channels) {

Should probably use g_atomic_int_get() here then :) Other than that this looks
good

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.