[Bug 690267] interleave: negotiation failure on sinkpads when channel-mask is specified

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=690267
  GStreamer | gst-plugins-good | git

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #231732|none                        |needs-work
             status|                            |

--- Comment #10 from Sebastian Dröge <slomo at circular-chaos.org> 2012-12-18 11:20:37 UTC ---
Review of attachment 231732:
 --> (https://bugzilla.gnome.org/review?bug=690267&attachment=231732)

Looks good except for:

::: gst/interleave/interleave.c
@@ +862,3 @@
+      if (g_atomic_int_get (&self->configured_sinkpads_counter) ==
+          self->channels) {
+        ret = gst_interleave_sink_setcaps (self, data->pad, caps);

You should just pass the GstAudioInfo here

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.