[Bug 668847] [0.11] deinterleave port

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=668847
  GStreamer | gst-plugins-good | 0.11.x

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #206872|none                        |needs-work
             status|                            |

--- Comment #4 from Sebastian Dröge <slomo at circular-chaos.org> 2012-02-06 11:29:42 UTC ---
Review of attachment 206872:
 --> (https://bugzilla.gnome.org/review?bug=668847&attachment=206872)

Looks good in general but:

::: gst/interleave/deinterleave.c
@@ -73,3 @@
     GST_PAD_SRC,
     GST_PAD_SOMETIMES,
-    GST_STATIC_CAPS ("audio/x-raw-int, "

There's no format in the src/sink template caps anymore. Please add that again

@@ +334,3 @@

+  if (!gst_audio_info_from_caps (&self->audio_info, caps))
+    goto no_channels;

no_channels is wrong here, failing to parse the caps means that the caps are
invalid in general

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.