[Bug 670850] collectpads2 port of adder has a regression for buzztard

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=670850
  GStreamer | gst-plugins-base | 0.10.x

--- Comment #4 from Stefan Sauer (gstreamer, gtkdoc dev) <ensonic at sonicpulse.de> 2012-02-27 09:44:49 UTC ---
git bisect start gst/adder
git bisect good 14644457b06f48b26f32f88ef91e1286a48ebe24
git bisect bad origin/master
Bisecting: 2 revisions left to test after this (roughly 1 step)
[bcaf5890aa6eb1c4a18b8dd71eacb22aadba0ead] adder: send a flush event before
trying to get the stream lock

git bisect good
Bisecting: 0 revisions left to test after this (roughly 1 step)
[85c10b0b24a58c1b5ec9aa05ea4ffa98ba99ed76] adder: do not send too many
flush-stop events

git bisect bad
Bisecting: 0 revisions left to test after this (roughly 0 steps)
[1da30adc1aeafd36b15b8d083fe2178524619479] adder: use the stream lock where
appropriate

git bisect good
85c10b0b24a58c1b5ec9aa05ea4ffa98ba99ed76 is the first bad commit
commit 85c10b0b24a58c1b5ec9aa05ea4ffa98ba99ed76
Author: Vincent Penquerc'h <vincent.penquerch at collabora.co.uk>
Date:   Fri Dec 16 17:32:41 2011 +0000

    adder: do not send too many flush-stop events

    GstCollectPads2 now allows us to override the event function,
    so we can withhold flush stop events if none are to be sent.

    https://bugzilla.gnome.org/show_bug.cgi?id=666379

:040000 040000 da80620b5dfd1bdde682e232755382e98f87913a
c8ec51e6b51c268e764184cdff45d304fc629eea M    gst

and indeed just git revert -n 85c10b0 make it work again.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.