[Bug 667292] gstfilesrc: Check for posix_madvise(), and use it, as well as madvise()

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Wed Jan 4 17:00:49 PST 2012


https://bugzilla.gnome.org/show_bug.cgi?id=667292
  GStreamer | gstreamer (core) | git

Tim-Philipp Müller <t.i.m> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEEDINFO
                 CC|                            |t.i.m at zen.co.uk,
                   |                            |thaytan at mad.scientist.com

--- Comment #1 from Tim-Philipp Müller <t.i.m at zen.co.uk> 2012-01-05 01:00:47 UTC ---
Hrm, this is correct of course, but I wonder if we shouldn't just remove the
madvise calls and be done with it instead. Not only is the mmap() code path
disabled by default, but then the sequential property is FALSE by default as
well, and it's all really pretty much unsupported and a bad idea and just a
microoptimisation really, and removed in 0.11 already.


I also wonder if we really need all that configure stuff, or if we can't just
cheat and get away with doing something like:

#if defined (POSIX_MADV_SEQUENTIAL)
   posix_madvise (...)
#else defined (MADV_SEQUENTIAL)
  madvise (...)
#endif

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list