[Bug 667681] New: gst_video_format_new_caps should generate caps with host endianness for 16-bit rgb formats

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Wed Jan 11 02:44:28 PST 2012


https://bugzilla.gnome.org/show_bug.cgi?id=667681
  GStreamer | gst-plugins-base | 0.10.35

           Summary: gst_video_format_new_caps should generate caps with
                    host endianness for 16-bit rgb formats
    Classification: Platform
           Product: GStreamer
           Version: 0.10.35
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: gst-plugins-base
        AssignedTo: gstreamer-bugs at lists.freedesktop.org
        ReportedBy: kiagiadakis.george at gmail.com
         QAContact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---


Created an attachment (id=205011)
 View: https://bugzilla.gnome.org/attachment.cgi?id=205011
 Review: https://bugzilla.gnome.org/review?bug=667681&attachment=205011

Patch that fixes the bug

Unlike all the other formats in the GstVideoFormat enum, the 16-bit rgb formats
(RGB16, BGR16, RGB15, BGR15) use the host's endianness in the
GST_VIDEO_CAPS_RGB_16 and related macros and also gst_video_format_parse_caps
expects these caps to have the host's endianness on them. However, the
gst_video_format_new_caps method generates caps with endianness = G_BIG_ENDIAN
always, which gives a mismatch and the generated caps neither match the static
caps in video.h nor are parsed by gst_video_format_parse_caps.

Here is a patch that fixes this problem, together with additions in the
libs/video unit test to ensure that this is correct.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list