[Bug 667300] basesrc: fixes potential caps-memoryleak

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Thu Jan 12 11:45:20 PST 2012


https://bugzilla.gnome.org/show_bug.cgi?id=667300
  GStreamer | gstreamer (core) | git

--- Comment #4 from Tim-Philipp Müller <t.i.m at zen.co.uk> 2012-01-12 19:45:16 UTC ---
Ah, yes. But the code upstream (both git and 0.10.35) is:

  2663      /* get the peer caps */
  2664      peercaps = gst_pad_peer_get_caps_reffed (GST_BASE_SRC_PAD
(basesrc));
  2665      GST_DEBUG_OBJECT (basesrc, "caps of peer: %" GST_PTR_FORMAT,
peercaps);
  2666      if (peercaps) {
  2667        /* get intersection */
  2668        caps =
  2669            gst_caps_intersect_full (peercaps, thiscaps,
GST_CAPS_INTERSECT_FIRST);
  2670        GST_DEBUG_OBJECT (basesrc, "intersect: %" GST_PTR_FORMAT, caps);
  2671        gst_caps_unref (peercaps);
  2672      } else {
  2673        /* no peer, work with our own caps then */
  2674        caps = gst_caps_copy (thiscaps);
  2675      }
  2676      gst_caps_unref (thiscaps);

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list