[Bug 668097] [subtitleoverlay] fix state change stall on PAUSED->READY->PAUSED (patch)

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=668097
  GStreamer | gst-plugins-base | 0.10.x

Vincent Penquerc'h <vincent.penquerch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|HEAD                        |0.10.37

--- Comment #2 from Vincent Penquerc'h <vincent.penquerch at collabora.co.uk> 2012-01-20 17:36:35 UTC ---
It makes sense to me.
Thanks for the patch.

commit dd8f9aca92df070157172bdeb97c93c33a3d5c22
Author: Anssi Hannula <anssi.hannula at iki.fi>
Date:   Tue Jan 17 16:05:41 2012 +0200

    subtitleoverlay: fix state change stall on PAUSED->READY->PAUSED

    After a PAUSED->READY change the sink pads are currently not set to
    blocking state. When the element is set back to PAUSED, the change will
    be done asynchronously, but as the _pad_blocked_cb() callback is now not
    called, the state change never completes.

    Fix that by setting the sink pads to blocking state on a PAUSED->READY
    change, which ensures that the _pad_blocked_cb() is called when needed
    on any future READY->PAUSED change. The sink pads are already put to
    blocking state on NULL->READY change, so this behavior is consistent.

    Fixes bug #668097.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.