[Bug 668380] New: [h264parse] [codecparsers] gst_h264_parse_hrd_parameters not reading cbr_flag

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=668380
  GStreamer | gst-plugins-bad | git

           Summary: [h264parse] [codecparsers]
                    gst_h264_parse_hrd_parameters not reading cbr_flag
    Classification: Platform
           Product: GStreamer
           Version: git
        OS/Version: All
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: gst-plugins-bad
        AssignedTo: gstreamer-bugs at lists.freedesktop.org
        ReportedBy: jonas at hallerud.se
         QAContact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---


Created an attachment (id=205736)
 View: https://bugzilla.gnome.org/attachment.cgi?id=205736
 Review: https://bugzilla.gnome.org/review?bug=668380&attachment=205736

Patch that read cbr_flag in gst_h264_parse_hrd_parameters

gst_h264_parse_hrd_parameters in gst-libs/gst/codecparsers/gsth264parser.c is
not reading cbr_flag. This breaks parsing of the rest of vui_parameters, and
gst_h264_parse_vui_parameters returns failure. This propagates so the parsing
of the entire SPS is deemed as a failure. Basically this renders the parsed
stream useless.

The fix is simple, just read one more bit in gst_h264_parse_hrd_parameters. The
flag is already declared in GstH264HRDParams.

legacyh264parse read this flag but it seems to be overlooked in the new parser.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.