[Bug 669036] New: Missing include in gstpreset.h causes build error

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=669036
  GStreamer | gstreamer (core) | git

           Summary: Missing include in gstpreset.h causes build error
    Classification: Platform
           Product: GStreamer
           Version: git
        OS/Version: All
            Status: UNCONFIRMED
          Severity: major
          Priority: Normal
         Component: gstreamer (core)
        AssignedTo: gstreamer-bugs at lists.freedesktop.org
        ReportedBy: joaopizani at gmail.com
         QAContact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---


I was trying to compile gstreamermm-0.10 on Windows, and then gcc complained
that "GST_PADDING" was "not declared at this scope", namely, in the file
"/usr/local/include/gstreamer-0.10/gst/gstpreset.h", that is, in my GSTREAMER
CORE installation.

Very puzzled with that error, I quickly grep'ed through my system looking for
the definition of the GST_PADDING macro (as I found out). It's defined in
gst/gstconfig.h.

So I just added the line

" #include <gst/gstconfig.h> "

to the file and compilation WORKED®.


I could send you the patch with this one-line change, but I am afraid that
gst/gstpreset.h might be somehow generated, could you tell me whether a patch
would be useful?

Here's what I think that made this bug remain unnoticed until now:
People included gst/gstpreset.h in their client files, BUT the definition of
GST_PADDING was also always available through some other path in the include
graph (thus directly or indirectly, they were including gst/gstconfig.h).

However, the bug (missing include) became apparent as an external library tried
to use gst/gstpreset.h without an EXTRA PATH including gst/gstconfig.h (namely,
this library was gstreamermm).

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.