[Bug 668762] regression: playbin2: still frame dvd menu doesn't come up with flags |= deinterlace

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=668762
  GStreamer | gst-plugins-base | git

--- Comment #7 from Vincent Penquerc'h <vincent.penquerch at collabora.co.uk> 2012-01-30 17:19:48 UTC ---
Back hacking on it, I have a bodge that "fixes" it, but doesn't appear to fix
the root cause. Somehow, two threads are stuck on a blocked pad, one with a
sink message event, and one with a custom event from the DVD demuxer. and with
in gst_subtitle_overlay_subtitle_sink_event. That AFAIK should not happen, and
should be fixed.


diff --git a/gst/playback/gstsubtitleoverlay.c
b/gst/playback/gstsubtitleoverlay.c
index 126ffd2..0f3657f 100644
--- a/gst/playback/gstsubtitleoverlay.c
+++ b/gst/playback/gstsubtitleoverlay.c
@@ -2082,7 +2082,11 @@ gst_subtitle_overlay_subtitle_sink_event (GstPad * pad,
GstEvent * event)
       break;
   }

-  ret = gst_proxy_pad_event_default (pad, gst_event_ref (event));
+  if (GST_EVENT_TYPE (event) != GST_EVENT_CUSTOM_DOWNSTREAM_OOB) {
+    ret = gst_proxy_pad_event_default (pad, gst_event_ref (event));
+  } else {
+    ret = TRUE;
+  }

   if (GST_EVENT_TYPE (event) == GST_EVENT_NEWSEGMENT) {
     gboolean update;

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.