[Bug 666352] 2bit DVB sub-pictures wrongly displayed

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=666352
  GStreamer | gst-plugins-bad | 0.10.35

Mark Nauwelaerts <mnauw> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |mnauw at users.sourceforge.net
         Resolution|                            |FIXED
   Target Milestone|HEAD                        |0.10.24

--- Comment #7 from Mark Nauwelaerts <mnauw at users.sourceforge.net> 2012-07-09 16:23:26 UTC ---
Applying this patch has 3 subtitles coming up OK for me (and timing issues
would then be another bug anyway), so considering this fixed:

commit a908339fee1e641961764f3281720aca1e414630
Author: Mart Raudsepp <mart.raudsepp at collabora.com>
Date:   Wed Dec 21 13:00:27 2011 +0200

    dvbsuboverlay: Handle non_modifying_colour_flag correctly in the RLE
handlers

    The check for when to not memset was checking on an undeterministic 'bits'
variable value,
    which is only meant to be used inside the loop earlier when it is supposed
to check if
    clut_index is 1 together with non_mod set, as per spec:

    "non_modifying_colour_flag:  If set to '1' this indicates that the CLUT
entry value '1'
    is a non modifying colour. When the non modifying colour is assigned to an
object pixel,
    then the pixel of the underlying region background or object shall not be
modified. This
    can be used to create "transparent holes" in objects."

    https://bugzilla.gnome.org/show_bug.cgi?id=666352

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.