[Bug 680706] New: Segfault on directsoundsink when AC3 support is tested after the DirectSound buffer is created

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=680706
  GStreamer | gst-plugins-good | 0.10.36

           Summary: Segfault on directsoundsink when AC3 support is tested
                    after the DirectSound buffer is created
    Classification: Platform
           Product: GStreamer
           Version: 0.10.36
        OS/Version: Windows
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: gst-plugins-good
        AssignedTo: gstreamer-bugs at lists.freedesktop.org
        ReportedBy: xartigas.bugzilla at gmail.com
         QAContact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---


Created an attachment (id=219741)
 --> (https://bugzilla.gnome.org/attachment.cgi?id=219741)
Do not overwrite DS buffer when testing for AC3 support

Right now, the gst_directsound_probe_supported_formats function overwrites the
dsoundsink->pDSBSecondary variable, which is not a bad thing if it has not been
used yet.
Under some circumstances, though, this method can be called when the DS buffer
is already created and in use.

The attached patch uses a temporary variable to hold the test buffer, and
leaves the sink's own buffer alone.

This fixes a segfault in DS for me when playing some DVDs.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.