[Bug 680767] [appsrc] rework as GstBuffer's don't have caps anymore

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Sun Jul 29 05:38:52 PDT 2012


https://bugzilla.gnome.org/show_bug.cgi?id=680767
  GStreamer | gst-plugins-base | git

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #219810|none                        |needs-work
             status|                            |

--- Comment #2 from Sebastian Dröge <slomo at circular-chaos.org> 2012-07-29 12:38:51 UTC ---
Review of attachment 219810:
 --> (https://bugzilla.gnome.org/review?bug=680767&attachment=219810)

Looks good except

::: gst-libs/gst/app/gstappsrc.c
@@ +938,1 @@
   GST_OBJECT_UNLOCK (appsrc);

Here you're using the object lock instead of priv->mutex to protect the
new_caps field

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list