[Bug 540891] [flac] Support embedded cuesheets

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=540891
  GStreamer | gst-plugins-good | git

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #219775|none                        |needs-work
             status|                            |

--- Comment #11 from Sebastian Dröge <slomo at circular-chaos.org> 2012-07-29 12:43:32 UTC ---
Review of attachment 219775:
 --> (https://bugzilla.gnome.org/review?bug=540891&attachment=219775)

::: ext/flac/gstflacenc.c
@@ +510,3 @@
+    return FALSE;
+
+  for (i = 0; i < n_tracks; i++) {

Iterating over GList should be done like
for (l = list; l; l = l->next) {
  GstTocEntry *entry = l->data;
  [...]
}

@@ +512,3 @@
+  for (i = 0; i < n_tracks; i++) {
+    entry = list->data;
+    gst_toc_entry_get_start_stop_times (entry, &start, &stop);

You need to check that the TOC event is of a format you can actually support,
i.e. just a flat TOC with a number of title/chapter entries. Everything else
can't be handled by cuesheets.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.