[Bug 634407] decodebin2 should expose pads in a deterministic order

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=634407
  GStreamer | gst-plugins-base | unspecified

Stefan Sauer (gstreamer, gtkdoc dev) <ensonic> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #219836|none                        |reviewed
             status|                            |

--- Comment #37 from Stefan Sauer (gstreamer, gtkdoc dev) <ensonic at sonicpulse.de> 2012-07-30 18:35:59 UTC ---
Review of attachment 219836:
 --> (https://bugzilla.gnome.org/review?bug=634407&attachment=219836)

::: libs/gst/base/gstbaseparse.c
@@ +2852,3 @@
   if (G_UNLIKELY (parse->priv->push_stream_start)) {
+    GstQuery *query;
+    gchar *uri;

maybe call this stream_id as in the random-number case it is not a uri (and we
don't really require one anyway).

@@ +2863,3 @@
+    }
+
+    if (gst_pad_peer_query (parse->sinkpad, query)) {

The comment says MD5 and the code SHA256

::: libs/gst/base/gstbasesrc.c
@@ +840,3 @@
+    g_checksum_update (cs, (const guchar *) uri, strlen (uri));
+
+    } else {

urgs, copy'n'paste. But probably still too specific to move to a utility
function?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.