[Bug 540891] [flac] Support embedded cuesheets

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=540891
  GStreamer | gst-plugins-good | git

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #219883|none                        |needs-work
             status|                            |

--- Comment #14 from Sebastian Dröge <slomo at circular-chaos.org> 2012-07-31 14:27:11 UTC ---
Review of attachment 219883:
 --> (https://bugzilla.gnome.org/review?bug=540891&attachment=219883)

::: ext/flac/gstflacenc.c
@@ +515,3 @@
+    entry = list->data;
+    if (!gst_toc_entry_is_sequence (entry))
+      return FALSE;

You might've added cuesheets to the encoder already for the first few elements
and then return FALSE here. You must first check if the TOC is valid in all
elements, and only afterwards add the cuesheet tracks.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.