[Bug 634407] decodebin2 should expose pads in a deterministic order

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=634407
  GStreamer | gst-plugins-base | unspecified

Stefan Sauer (gstreamer, gtkdoc dev) <ensonic> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #219991|none                        |reviewed
             status|                            |

--- Comment #42 from Stefan Sauer (gstreamer, gtkdoc dev) <ensonic at sonicpulse.de> 2012-07-31 20:37:35 UTC ---
Review of attachment 219991:
 --> (https://bugzilla.gnome.org/review?bug=634407&attachment=219991)

::: gst/gstutils.c
@@ +3543,3 @@
+ * Creates a stream-id for the source #GstPad @pad by combining the
+ * upstream information with the optional @stream_id of the stream
+ * of @pad. @pad must have a parent #GstElement and must have zero

"parent #GstElement and must have" -> "parent #GstElement which must have"

@@ +3592,3 @@
+
+      /* And then generate an MD5 sum of the URI */
+  g_return_val_if_fail (parent->numsinkpads <= 1, NULL);

still MD5 <-> SHA256 :/

@@ +3617,3 @@
+  g_free (upstream_stream_id);
+
+      gst_event_unref (upstream_event);

perhaps:

if (stream_id) {
  gchar *id = g_strconcat (upstream_stream_id, "/", stream_id, NULL);
  g_free (upstream_stream_id);
  return id;
} else {
  return upstream_stream_id;
}

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.