[Bug 677335] Incompatible caps can be accepted and dataflow happens

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=677335
  GStreamer | gstreamer (core) | 0.11.x

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|HEAD                        |0.10.37

--- Comment #2 from Sebastian Dröge <slomo at circular-chaos.org> 2012-06-04 07:33:13 UTC ---
Both fixes implemented now, the acceptcaps change in 0.10 might need to be
reverted later if the performance problems are too severe.

commit 7558fd21eeb0bf7fcaaf78dcc9159c05780e0b56
Author: Sebastian Dröge <sebastian.droege at collabora.co.uk>
Date:   Mon Jun 4 09:31:07 2012 +0200

    pad: Check via gst_pad_accept_caps() if a sinkpad accepts caps

    instead of just checking if the pad template caps would allow the caps.

    The actually supported caps can be far more restrictive than the
    template caps and only checking for the template caps can cause
    incompatible caps to be set on a pad.

    Fixes bug #677335.

commit 1c0764f764a9ce574cbea4ef0fdbd161f606ba12
Author: Sebastian Dröge <sebastian.droege at collabora.co.uk>
Date:   Mon Jun 4 09:29:22 2012 +0200

    ghostpad: Don't propagate setcaps() calls to the target pads

    The core will do this during dataflow already and additionally
    does compatibility checks then. Let it be handled by the core
    as for every other pad too.

    Fixes bug #677335.



commit 991ac561e19b71ec273559ead1f78bd216202359
Author: Sebastian Dröge <sebastian.droege at collabora.co.uk>
Date:   Mon Jun 4 09:27:35 2012 +0200

    pad: Only forward caps events to a pad if it accepts the caps

    Fixes bug #677335.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.