[Bug 678433] 0.11: x264enc broken after latest port

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Tue Jun 19 23:43:58 PDT 2012


https://bugzilla.gnome.org/show_bug.cgi?id=678433
  GStreamer | gst-plugins-ugly | 0.11.x

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #216776|none                        |needs-work
             status|                            |

--- Comment #1 from Sebastian Dröge <slomo at circular-chaos.org> 2012-06-20 06:43:52 UTC ---
Review of attachment 216776:
 --> (https://bugzilla.gnome.org/review?bug=678433&attachment=216776)

::: ext/x264/gstx264enc.c
@@ +1567,3 @@
+      tags = gst_tag_list_copy (tags);
+      s = gst_event_get_structure (event);
+      event = gst_event_new_tag (gst_structure_get_name (s), tags);

I don't think this is correct. The reference of the event passed to this
function is owned by the function. Making writable should just work, and the
way you're doing it now you're leaking the original event.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list