[Bug 677306] [wavparse] TOC support

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=677306
  GStreamer | gst-plugins-good | git

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #216853|none                        |needs-work
             status|                            |

--- Comment #6 from Sebastian Dröge <slomo at circular-chaos.org> 2012-06-20 17:06:20 UTC ---
Review of attachment 216853:
 --> (https://bugzilla.gnome.org/review?bug=677306&attachment=216853)

::: gst/wavparse/gstwavparse.c
@@ +1159,3 @@
+  if (wav->toc) {
+    GST_WARNING_OBJECT (wav, "found another cue chunk");
+    return FALSE;

Still returning FALSE here

@@ +1167,3 @@
+    return TRUE;
+  }
+  cue = g_new (GstWavParseCue, ncues);

You have to free this later

@@ +2683,3 @@
+      res = TRUE;
+      if (!wav->toc)
+        gst_toc_free (toc);

The freeing here is wrong now. Remove the two lines. Other than that it's
better. Want to provide the same change for matroskademux too? :)

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.