[Bug 377713] mpeg2dec: should negotiate alignment of 16 bytes with xvimagesink et al.

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=377713
  GStreamer | gst-plugins-base | git

Tim-Philipp Müller <t.i.m> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[xvimagesink] buffers       |mpeg2dec: should negotiate
                   |should be aligned to 16     |alignment of 16 bytes with
                   |byte boundaries             |xvimagesink et al.

--- Comment #5 from Tim-Philipp Müller <t.i.m at zen.co.uk> 2012-06-22 08:25:39 UTC ---
I didn't say there was a problem, I meant that looking at the code it wasn't at
first glance obvious to me that it does in fact negotiate/request 16-byte
alignment in all code paths, or even in the most common code path.

I only found this code in gst_mpeg2dec_alloc_sized_buf():

    GstAllocationParams params = { 0, 15, 0, 0 };
    frame->output_buffer = gst_buffer_new_allocate (NULL, size, &params);

but that's only used when we have to crop ourselves and not related to the
bufferpool, is it?

Could you point me towards the line where the alignment is configured in the
normal case?

Moving to mpeg2dec.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.