[Bug 678429] souphttpsrc: should return GST_FLOW_ERROR from create function in case of HTTP error 404 not found

Fri Jun 22 14:56:59 PDT 2012

https://bugzilla.gnome.org/show_bug.cgi?id=678429
  GStreamer | gst-plugins-good | git

--- Comment #5 from Norbert <nwaschbu at opentv.com> 2012-06-22 21:56:52 UTC ---
Created an attachment (id=217051)
 --> (https://bugzilla.gnome.org/attachment.cgi?id=217051)
Patch for 678429

Attaching patch as requested.  Please provide feedback.  

Without this patch we see the following:
========================================
1) gst_soup_http_src_got_headers_cb detects error and Gst Error message 404 Not
Fount is being sent.  In addition, src->ret is being set to GST_FLOW_ERROR.
2) g_main_loop is NOT being quit.
3) gst_soup_http_src_got_chunk_cb gets called with 322 bytes of data (see HTML
body below)
4) gst_soup_http_src_got_chunk_cb overwrites error code in src->ret with
GST_FLOW_OK.
5) gst_soup_http_src_create returns GST_FLOW_OK (instead of GST_FLOW_ERROR to
trigger Internal Data Flow Error)
6) The 322 bytes (of MIME type html/text) are pushed over the src pad of the
Soup HTTP source element.

With the patch we see the following:
========================================
1) gst_soup_http_src_got_headers_cb detects error and Gst Error message 404 Not
Fount is being send.  In addition, src->ret is being set to GST_FLOW_ERROR.
2) g_main_loop is being quit.
3) gst_soup_http_src_create returns GST_FLOW_ERROR which triggers an Internal
Data Flow Error.
4) No data is being pushed over the src pad of the Soup HTTP source element.

<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML 2.0//EN"> 
<html><head> 
<title>404 Not Found</title> 
</head><body> 
<h1>Not Found</h1> 
<p>The requested URL /mp4/1Winnie The Pooh - Official Trailer [HD].mp4 was not 
found on this server.</p> 
<hr> 
<address>Apache/2.2.15 (Fedora) Server at 10.4.2.100 Port 80</address> 
</body></html> 
<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML 2.0//EN"> 
<html><head> 
<title>404 Not Found</title> 
</head><body> 
<h1>Not Found</h1> 
<p>The requested URL /mp4/1Winnie The Pooh - Official Trailer [HD].mp4 was not 
found on this server.</p> 
<hr> 
<address>Apache/2.2.15 (Fedora) Server at 10.4.2.100 Port 80</address> 
</body></html>

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.