[Bug 678575] [0.10] regression: playbin2 visualisation sync messed up after seeking
GStreamer (bugzilla.gnome.org)
bugzilla at gnome.org
Fri Jun 22 17:23:49 PDT 2012
https://bugzilla.gnome.org/show_bug.cgi?id=678575
GStreamer | gst-plugins-base | 0.10.x
--- Comment #1 from Thiago Sousa Santos <thiago.sousa.santos at collabora.co.uk> 2012-06-23 00:23:42 UTC ---
Created an attachment (id=217053)
View: https://bugzilla.gnome.org/attachment.cgi?id=217053
Review: https://bugzilla.gnome.org/review?bug=678575&attachment=217053
bin: do not skip state_changes of other bins
The problem was caused by patch:
commit 554b81ed243c27385e11b925722b91c2fafdcfb4
bin: try harder to avoid state changes in wrong direction
When the bin does an upward state change, try to avoid doing a downward
state
change on the child and vice versa.
Add some more unit tests for this fix.
Fixes https://bugzilla.gnome.org/show_bug.cgi?id=621833
And some bin's state changes were being skipped on this pipeline, leaving some
element's base_time broken, causing sync issues. The patch attached is really
simple. It just won't skip bins state changes. If we think that skipping bins
state changes is good, we need to propagate the base_time to children even when
se skip a bin state change (add some extra function to gstbin to do that),
which
is equally simple.
--
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list