[Bug 678742] [0.11] [API] GstToc API review

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=678742
  GStreamer | gstreamer (core) | 0.11.x

--- Comment #3 from Tim-Philipp Müller <t.i.m at zen.co.uk> 2012-06-25 10:14:25 UTC ---
> The idea of the entry types was to have one for "alternatives" (angles, a set
> of chapters with an alternate ending, ...) and "sequences" (chapters, titles,
> ...). Maybe there could be a tag or something else for the adding this kind of
> information to the entries?

What do you mean with 'this kind of information' here? The track/title/chapter
thing or the sequence thing?

Why not just make it explicit? I understand the original distinction, I'm just
saying that it doesn't make sense to drop the distinction between
titles/tracks/chapters and that applications would want to know which one it
was. It's also less intuitive.


> titles[chapters]->chapters[chapters]

It doesn't make sense, sorry. At the very least the CHAPTERS enum is completely
misnamed and should be ENTRY_TYPE_SEQUENCE_THINGY then. Which perhaps makes it
more obvious how absurd this is.


> >  - how do I represent a simple Audo CD with
> >    a number of CD tracks? Using 'chapters'
> >    here feels a bit wrong
> 
> chapters :)

It's just wrong.


> >  - I there's no reason not to, I will add
> >     additional entry types for
> >     TRACK, TITLE, ANGLE
> 
> Maybe make the entry type an entry type "class" (alternative or sequence) and
> additionally something else to say that this is a track, title, angle, ...?

Could do two different enums, or something with flags, or add API to check
whether it's a sequence or alternative.

 > >  - (there should generally be
> >     getter/setter API, but that's just
> >     a nitpick compared to the other
> >     issues)
> 
> What do you mean with getter/setter API?

The structs should be opaque instead of people poking at the members.


> If there's only one edition and you don't have specific metadata for it, just
> start with the chapters at the top-level?
> What would you suggest instead?

That seems fine.


> Also note that this API is in 0.10 too

I know, but I don't care about that and I don't intend to spend time fixing it
up in 0.10.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.