[Bug 678546] [hlsdemux] supply a more useful user-agent

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=678546
  GStreamer | gst-plugins-bad | git

--- Comment #5 from Sebastian Dröge <slomo at circular-chaos.org> 2012-06-26 08:06:41 UTC ---
(In reply to comment #4)
> (In reply to comment #3)
> > Instead of relying on souphttpsrc you could as well check if the element has an
> > "user-agent" property which takes string arguments. See element_has_property()
> > in gst-plugins-base/gst/playback/gstplaysink.c for example.
> 
> I considered this but I think this is risky since it makes assumptions about
> the functionality of potentially unknown modules. I don't see a way that we can
> guarantee that a "user-agent" property works as expected. The souphttpsrc
> property is already a bit wonky since it interprets a trailing space character
> in the agent to mean that it should insert an extra string at the end with the
> libsoup version.

While this is potentially true, we're doing the same in other elements too
already. This is a bit like an implicit interface and other, new elements (if
automatically used) should if possible mimic the behaviour and interface of
existing elements.

(This thing about the extra space is interesting though, doesn't really make
sense, does it? :) )

> Basing the fetching around a known module also opens up further possibilities,
> like specifying the cookies and auth headers, or possibly a custom timeout
> value which might be useful.

Same as above, any new http source should just do the same as souphttpsrc if it
wants to work as good.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.