[Bug 670257] [v4l2src] fails to renegotiate from ready to paused

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=670257
  GStreamer | gst-plugins-good | git

--- Comment #25 from Youness Alaoui <youness.alaoui at collabora.co.uk> 2012-06-29 01:52:38 UTC ---
@Robert: Yes, my patch works but it's for the 0.10 branch only. What Wim did is
to port it to the 1.0 branch of Gstreamer with this patch :
http://cgit.freedesktop.org/gstreamer/gst-plugins-good/commit/?id=1b09bc609a578e731f0dbc8f6e698e25d8f4c5f8
But it failed so he reverted it here :
http://cgit.freedesktop.org/gstreamer/gst-plugins-good/commit/?id=77f33e591fc0cbf2fbcb6cddc5803be766f206de
The reason for the revert being : "Seems to make libv4l2 complain, maybe
because we call REQBUFS with 0 buffers before we allocated buffers."

@Wim: Humm.. I just tried the same as you on the 0.10 branch, I added a call to
REQBUFS with count=0 before the allocation happens and the driver didn't
complain, so that's not it.
Also note that the fix you had (freeing the buffers right before allocating new
ones) wouldn't fix the bug here because the renegotiation has to happen when no
buffers are allocated on the kernel side. So the REQBUFS with count=0 has to
happen before the VIDIOC_S_FMT happens (which itself happens before the
bufferpool is allocated/configured).

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.