[Bug 671047] [discoverer] don't change result when processing missing plugin errors

Sat Mar 3 05:57:57 PST 2012

https://bugzilla.gnome.org/show_bug.cgi?id=671047
  GStreamer | gst-plugins-base | git

Tim-Philipp Müller <t.i.m> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
                 CC|                            |t.i.m at zen.co.uk
         Resolution|                            |FIXED
   Target Milestone|HEAD                        |0.10.37

--- Comment #2 from Tim-Philipp Müller <t.i.m at zen.co.uk> 2012-03-03 13:57:53 UTC ---
Thanks!

IMHO there's still something a bit dodgy about all of this. I think the GError
should be set/overwritten alongside the return value as needed, but there's
clearly a bug here, and the patch fixes that, so let's do that for now. I've
changed it slightly to also consider STREAM_CODEC_NOT_FOUND errors which are
like CORE_MISSING_PLUGIN. Hope I didn't mess anything up.

 commit 85a7b8f5622536de9b888f58c7c6ca1b15834b78
 Author: Tim-Philipp Müller <tim.muller at collabora.co.uk>
 Date:   Sat Mar 3 13:51:55 2012 +0000

    tests: add test to check discoverer return code for missing plugins case

    https://bugzilla.gnome.org/show_bug.cgi?id=671047

 commit bc1fb43408520e62661598d63ece648801e06f41
 Author: Jonathan Matthew <jonathan at d14n.org>
 Date:   Wed Feb 29 21:25:24 2012 +1000

    discoverer: don't change result for missing plugin errors

    https://bugzilla.gnome.org/show_bug.cgi?id=671047

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.