[Bug 671909] Port base video encoding and decoding classes from gst-plugins-bad

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Tue Mar 13 02:24:11 PDT 2012

  GStreamer | gst-plugins-base | git

--- Comment #1 from Sebastian Dröge <slomo at circular-chaos.org> 2012-03-13 09:24:07 UTC ---
Other than everything mentioned in the bugs linked to this one now:
- gst_video_decoder_get_byte_time() is a really weird name :)
- GstVideoState/GstVideoFrame needs padding and probably still contains some
unused things. But I know that you planned to work on this next
- The adapters in the decoder instance struct should be hidden
- Check the ownership transfer of the frame parameter of _finish_frame(),
_drop_frame() and ::handle_frame(). Should be consistent with the ones in the
audio base classes and IIRC they are not
- gst_video_decoder_set_sync_point() and other frame-related things should
probably operate on the frames instead of the decoder. Feels weird to do it on
the decoder instead and also could be problematic if there's internal queueing
of more than a single frame inside the decoder
- The segment in the decoder should be public in the instance struct too, there
are always reasons to use it. Or be part of the GstVideoState
- ::event() vfuncs should probably be ::sink_event() and ::src_event(). Or
::event() and ::src_event()
- ::get_caps() vfuncs were really useful for the audio base classes and are
missing here
- The coder_hook/destroy_notify is probably hard to use for bindings

Most of this applies to decoder and encoder

Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.

More information about the gstreamer-bugs mailing list