[Bug 671909] Port base video encoding and decoding classes from gst-plugins-bad
bugzilla at gnome.org
Tue Mar 13 07:46:51 PDT 2012
GStreamer | gst-plugins-base | git
--- Comment #3 from Sebastian Dröge <slomo at circular-chaos.org> 2012-03-13 14:46:47 UTC ---
(In reply to comment #2)
> (In reply to comment #1)
> > Other than everything mentioned in the bugs linked to this one now:
> > - gst_video_decoder_get_byte_time() is a really weird name :)
> Indeed :) Any propositions ? I just re-used what was already there.
Not really :(
> > - The adapters in the decoder instance struct should be hidden
> And for the encoders also ?
> > - The segment in the decoder should be public in the instance struct too, there
> > are always reasons to use it. Or be part of the GstVideoState
> I'd say we need two. One for the input stream/context and one for the output
> stream/context. Especially important due to the delay/latency betwen input and
Yes, same for the "caps" btw (input could already have a different resolution
as the output for example)
> > - ::event() vfuncs should probably be ::sink_event() and ::src_event(). Or
> > ::event() and ::src_event()
Best to check what other base classes do here
> > - ::get_caps() vfuncs were really useful for the audio base classes and are
> > missing here
> *cough* You removed them when they were in -bad :) I'll put them back
The old ::get_caps() that was there was meant to provide the fixated srcpad
caps that were put on the pad and on the buffer. What I mean here now is a real
get_caps() like everywhere else :)
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs