[Bug 668483] video: add support for global-alpha multiplicator for overlay rectangles

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=668483
  GStreamer | gst-plugins-base | git

Tim-Philipp Müller <t.i.m> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #208333|none                        |committed
             status|                            |

--- Comment #12 from Tim-Philipp Müller <t.i.m at zen.co.uk> 2012-03-14 18:07:09 UTC ---
(From update of attachment 208333)
Pushed the fixes for premultiplied alpha, with some minor modifications here
and there (e.g. use g_memdup()). I fixed the unpremultiplying/premultiplying
functions differently (KISS). Also added a unit test.

Next time "git format-patch" formatted patches would be great, ideally one per
bug/issue.


commit 87a9e5634e3c44a02bb1dad9233a2cbd2c4f5311
Author: Tim-Philipp Müller <tim.muller at collabora.co.uk>
Date:   Wed Mar 14 17:59:31 2012 +0000

    tests: add unit test for premultiplied alpha handling of video overlay
rectangles

    https://bugzilla.gnome.org/show_bug.cgi?id=668483

commit 2c4b379470963ea2baff1e85db4f4568e53e83d2
Author: Tim-Philipp Müller <tim.muller at collabora.co.uk>
Date:   Wed Mar 14 17:46:23 2012 +0000

    video: overlay-composition: fix alpha premultiply and unpremultiply

    Fix component offsets for little endian systems.

    https://bugzilla.gnome.org/show_bug.cgi?id=668483

commit 027f5bb47182130ae1edb30de789e42f4305e2ca
Author: Holger Kaelberer <hk at getslash.de>
Date:   Wed Mar 14 17:28:57 2012 +0000

    video: overlay-composition: fix rectangle caching after alpha
(un)premultiplying

    If we are asked to (un)premultiply,we need to create the new rectangle
    with the right flags, so we can find it properly on subsequent cache
    lookups (also because it's wrong otherwise).

    https://bugzilla.gnome.org/show_bug.cgi?id=668483

commit 7a21d1eb32a02139236378f66e8a245cba5d35e0
Author: Holger Kaelberer <hk at getslash.de>
Date:   Wed Mar 14 17:18:47 2012 +0000

    video: overlay-composition: fix crash when doing
premultiplied<->unpremultiplied alpha conversion

    We need to copy the pixels before messing with them, not least
    because the buffer creation code below assumes it's ok to take
    ownership.

    Fixes crash caused by double-free.

    https://bugzilla.gnome.org/show_bug.cgi?id=668483

commit 6b7f25a2f07082be5fb95d676bf90fda91511204
Author: Holger Kaelberer <hk at getslash.de>
Date:   Wed Mar 14 16:42:24 2012 +0000

    video: overlay-composition: check the right flags when searching for a
cached rectangle

    Compare the flags of the *cached* rectangle to the desired flags when
    checking for a suitable rectangle in the cache.

    https://bugzilla.gnome.org/show_bug.cgi?id=668483

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.