[Bug 670588] generic/states check fails: GST_IS_PAD (pad) warning caused by facedetect element

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=670588
  GStreamer | gst-plugins-bad | 0.10.23

Tim-Philipp Müller <t.i.m> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|HEAD                        |0.10.24

--- Comment #6 from Tim-Philipp Müller <t.i.m at zen.co.uk> 2012-03-15 18:49:07 UTC ---
Should be fixed in git now (but may require other commits too, like the pad
template fix):


commit d405ea2e632363e560dd3784177f249196bb2bc1
Author: Tim-Philipp Müller <tim.muller at collabora.co.uk>
Date:   Thu Mar 15 16:52:44 2012 +0000

    faceoverlay: fix weird pad creation code

    The element would create normal pads in its instance_init function,
    and then later in NULL->READY create the elements it needs, remove
    the pads created in the instance_init function, and add new ghost
    pads instead. Not without saving the external peer pads of the old
    pads of course, which it would promptly re-link to the new ghost
    pads. Do all of that a bit differently.

    Fixes the generic/states.check unit test.

    https://bugzilla.gnome.org/show_bug.cgi?id=670588


commit 55b0f1e60168571ebbbd7a99ab51a687607a6619
Author: Tim-Philipp Müller <tim.muller at collabora.co.uk>
Date:   Thu Mar 15 17:42:56 2012 +0000

    faceoverlay: fix pad templates

    Use generic and unspecififed rgb/caps for now. The exact caps
    supported depend on the facedetect element and rsvgoverlay. It's
    not clear how this worked before, since facedetect only accepts
    24-bit RGB, but the caps advertised 32-bit ARGB/BGRA. In any case,
    we don't want to force anything really, so that if any of those
    elements acquires support for additional formats we pick those up
    automatically.

commit e1e827d364942ceb6f6fd61c6ae4bb5ff3db6fdc
Author: Tim-Philipp Müller <tim.muller at collabora.co.uk>
Date:   Thu Mar 15 17:26:14 2012 +0000

    rsvgoverlay: fix crash due to double adapter unref

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.