[Bug 671954] removesilence: add a property to output buffer without timestamp gap

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Sat Mar 17 13:51:23 PDT 2012

  GStreamer | gst-plugins-bad | git

David Schleef <ds> changed:

           What    |Removed                     |Added
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1

--- Comment #6 from David Schleef <ds at schleef.org> 2012-03-17 20:51:20 UTC ---
<drakkan1000> recently I did some work on removesilence plugin to make it
suitable for my use cases https://bugzilla.gnome.org/show_bug.cgi?id=671954
what do you think about? Can this changes be merged?
<ds> drakkan1000: could you deprecate the patches which are no longer valid?
<drakkan1000> ds, the posted patch are all valid
<drakkan1000> ds, they must be applied in the order I posted
<drakkan1000> if you want I can make a single patch but each one add a
different feature
<ds> we have a standard property name for enabling/disabling bus messages. 
it's called "silent", which is, uh, unfortunate
<drakkan1000> ds, ok I'll post a new patch renaming the property
<ds> there was some talk about doing this differently in 0.11
<ds> drakkan1000: i'd like to see the silence cutting configuration to be in
time, and a bit more flexible
<ds> drakkan1000: I think of this sort of like a patch file:  you want a
certain amount of context, and want to merge hunks if they're too close
<drakkan1000> ds, ok I'll try to do what you ask, should be a matter to do sum
the duration of each frame
<ds> so a property that determines how much silence to prepend to a hunk,
append to a hunk, and the minimum gap, i think would be the minimal set of
<ds> and although I would want this to ultimately work with sample precision,
frame precision is likely fine for now.  if someone wants sample precision,
they can do the hard work themselves
<ds> (but make sure the API makes sense for sample precision)
<ds> also, as a side comment, please don't abbreviate property names ("msgs")
<drakkan1000> ds, thanks for your suggestions
<ds> i'm still trying to decide about 'continuous-timestamp'.  I think there's
a better name out there, but 'squash' is the best I can think of, which fails
the "better" criterium
<ds> ahem, criterion

Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.

More information about the gstreamer-bugs mailing list