[Bug 540890] Need generic way of handling multi-track/chapters files

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=540890
  GStreamer | gstreamer (core) | git

Stefan Sauer (gstreamer, gtkdoc dev) <ensonic> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #209758|none                        |reviewed
             status|                            |

--- Comment #87 from Stefan Sauer (gstreamer, gtkdoc dev) <ensonic at sonicpulse.de> 2012-03-22 08:01:33 UTC ---
Review of attachment 209758:
 --> (https://bugzilla.gnome.org/review?bug=540890&attachment=209758)

::: gst/gsttoc.c
@@ +39,3 @@
+ * lists. You should use GST_TOC_ENTRY_TYPE_CHAPTER for generic TOC entry and
+ * GST_TOC_ENTRY_TYPE_EDITION for the entries which are considered to be
alternatives
+ * (like DVD angles, Matroska editions and so on).

Is the hierarchy at most two levels deep?
GstToc
  GstTocEntry (in GstToc.entries)
    GstTocEntry (in GstToc.subentries) 
    GstTocEntry (in GstToc.subentries) 
    ...
  GstTocEntry (in GstToc.entries)
    GstTocEntry (in GstToc.subentries)
    ...
  ...


Or is it arbitrary, so that GstTocEntries can have a list of GstTocEntries
again?

@@ +55,3 @@
+ * and gst_event_parse_toc_select() to parse received TOC select event. The
same rule for
+ * the #GstMessage: gst_message_new_toc() to create new TOC #GstMessage, and
+ * gst_message_parse_toc() to parse received TOC message. Also you can create
a new TOC query

For the toc parsing I am not sure how applications would iterate over the
content. Could point to the totem chapters plugin sources in a reply on this
bug?

@@ +482,3 @@
+GstToc *
+_gst_toc_from_structure (const GstStructure * toc)
+{

please add a comment for where this is needed.

@@ +647,3 @@
+GstStructure *
+_gst_toc_to_structure (const GstToc * toc)
+{

please add a comment for where this is needed.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.