[Bug 667352] [0.11] misc core API/bug comments/nitpicks
bugzilla at gnome.org
Tue Mar 27 04:14:14 PDT 2012
GStreamer | gstreamer (core) | 0.11.x
--- Comment #7 from Wim Taymans <wim.taymans at gmail.com> 2012-03-27 11:14:09 UTC ---
(In reply to comment #5)
> * tag event is sticky event, presumably with the intent of persisting these and
> delivering to downstream whenever possible. It also allows for multiple ones,
> which are distinguished by name. However, afaik, each tag event has the same
> name, which still only allows one event. So things will not turn out as
> persistent as expected/hoped, unless each element really sends all it has to in
> one tag event (and also with subsequent updates). Many (if not all) do not do
> so, and might be somewhat cumbersome to arrange it so (and undocumented as
It is true, we don't have an api to name the taglist. We can use the structure
API to change the name, though. I will have a look.
> * a GstVideoFrame holds a pointer to the buffer it is mapping which is not
> refcounted. That may be so intended and may work out well, but seems
> potentially tricky.
OK, I think it can be refcounted without problems.
> * afaics gst_buffer_pool_config_get returns (a.o.) caps with an extra ref,
> which seems not to be taken into account presently (documented or in code
> anywhere). It looks like this is not intended (and then needs some
> adjustment). But even if intended, a construction using gst_structure_id_get
> with multiple fields is tricky since if it fails it is not known whether or not
> it has succeeded enough for an extra ref to have already been taken.
I removed the extra ref.
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs