[Bug 667352] [0.11] misc core API/bug comments/nitpicks
bugzilla at gnome.org
Wed Mar 28 09:55:00 PDT 2012
GStreamer | gstreamer (core) | 0.11.x
--- Comment #14 from Mark Nauwelaerts <mnauw at users.sourceforge.net> 2012-03-28 16:54:59 UTC ---
(In reply to comment #13)
> (In reply to comment #12)
> > Even if that one is handled, a related problem might remain. That is, if one
> > event does not make it properly downstream, push_sticky currently makes
> > evens_foreach give up on the following events, so a subsequent EOS might never
> > make it through anymore (which is typically part of some error handling loop
> > cleanup/shutdown). One might say "so be it" but an EOS passing by does help to
> > avoid "hanging cases" and allows for "graceful degradation" (e.g. muxer
> > metadata etc).
> Maybe it could continue pushing the EOS (and only the EOS because the other
> events might not make sense without the previous events).
It probably should, since otherwise there can be lots of pipeline hanging near
the end. Also, dataflow (eventually) failing because of some event "failing"
(some return FALSE somewhere/time earlier) tends to happen rather
quietly/crypticly, since it generates a GST_FLOW_ERROR without a corresponding
GST_ELEMENT_ERROR (which normally should be, not sure whether here also is a
good thing), and a message less is one more chance to hang.
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs