[Bug 674791] [0.11] GstAdapter reports incorrect timestamps when buffers are merged

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=674791
  GStreamer | gstreamer (core) | 0.11.x

Wim Taymans <wim.taymans> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
                 CC|                            |wim.taymans at gmail.com
         Resolution|                            |FIXED
   Target Milestone|HEAD                        |0.11.x

--- Comment #1 from Wim Taymans <wim.taymans at gmail.com> 2012-05-01 08:54:35 UTC ---
I don't know.. Adapter should be rewritten using the new 0.11 memory objects,
it feels weird to add this new complexity. OTOH it might be better than leaving
the current broken behaviour. 

This problem is also in 0.10 but there is doesn't show up because most buffer
are not spanning. In 0.11 we always assume the buffer is spanning and use the
buffer API to let it merge when possible.

I finally decided to remove the try_merge_up entirely, it should not be called
often and if it is called, it would also break with 0.10. Hopefully it
encourages someone to rewrite with 0.11 features in mind.


commit 1b87a07d8e513b2e72a675eb5c101f6cdf666146
Author: Wim Taymans <wim.taymans at collabora.co.uk>
Date:   Tue May 1 10:50:32 2012 +0200

    adapter: remove _try_to_merge_up()

    It causes the timestamp to go wrong, should not cause much of a performance
    increase and in the cases where it is faster, it is broken in 0.10 as well.
    We should try to review this when rewriting the adapter for 0.11 memory
    features.

    Fixes https://bugzilla.gnome.org/show_bug.cgi?id=674791

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.