[Bug 675604] gst-python: fix compilation on windows

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=675604
  GStreamer | gst-python | 0.10.x

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #213575|none                        |reviewed
             status|                            |

--- Comment #4 from Sebastian Dröge <slomo at circular-chaos.org> 2012-05-09 07:43:50 UTC ---
Review of attachment 213575:
 --> (https://bugzilla.gnome.org/review?bug=675604&attachment=213575)

::: configure.ac
@@ +99,3 @@
+if test "x$platform_win32" = "xyes" ; then
+  # skip python cheks if compiling to windows
+  # $PYTHON_INCLUDES and PYTHON_LIBS should be set properly

Why can't you use AM_CHECK_PYTHON_HEADERS() or an equivalent on Windows?
Requiring the user to properly set this seems rather unintuitive

@@ +454,1 @@


Why do you remove the valgrind check?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.