[Bug 675451] a52dec: can update caps if original number of audio channels has changed

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=675451
  GStreamer | gst-plugins-ugly | 0.10.x

Julien Isorce <julien.isorce> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEEDINFO                    |UNCONFIRMED

--- Comment #2 from Julien Isorce <julien.isorce at gmail.com> 2012-05-09 13:59:43 UTC ---
(In reply to comment #1)
> The patch looks wrong, it compares flags against using_channels, it should
> probably only compare the flags related to the channels. the code around there
> is also a bit hard to follow.

In the original code, some lines later there is:

flags = a52dec->using_channels;

and also:

channels = flags & (A52_CHANNEL_MASK | A52_LFE);
...
a52dec->using_channels = channels;



So should I use:

if (a52dec->using_channels != flags & (A52_CHANNEL_MASK | A52_LFE)) {

instead of:

if (a52dec->using_channels != flags) {

?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.