[Bug 667850] rtpsession: creation should be signaled before validation

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Thu May 10 01:36:39 PDT 2012


https://bugzilla.gnome.org/show_bug.cgi?id=667850
  GStreamer | gst-plugins-good | unspecified

--- Comment #9 from Wim Taymans <wim.taymans at gmail.com> 2012-05-10 08:36:37 UTC ---
(In reply to comment #8)
> Well if you ask me then emitting "validated" before "new" makes the "new"
> signal redundant. This patch was just to revert order back to how the original

I agree, 'new' and 'validated' are a bit redundant

> code was before it got inadvertently changed by a early patch. If you have
> reasons for reversing the order, ie that "validated" should be before "new"
> because of behavior xyz than fine reject this patch. Other wise as you pointed
> out we should  probably change the order of all emissions of new and validate
> so that they are at least consistent.

I inclined to change it so the 'validated' is called before 'new' in all cases
because validation is supposed to happen before the SSRC is accepted and
considered 'new'.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list