[Bug 638168] textoverlay: don't return wrong-state when stopping while in text chain

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Fri May 11 01:35:51 PDT 2012


https://bugzilla.gnome.org/show_bug.cgi?id=638168
  GStreamer | gst-plugins-base | unspecified

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #213816|none                        |reviewed
             status|                            |

--- Comment #18 from Sebastian Dröge <slomo at circular-chaos.org> 2012-05-11 08:35:47 UTC ---
Review of attachment 213816:
 --> (https://bugzilla.gnome.org/review?bug=638168&attachment=213816)

Looks good but as discussed on IRC, subparse should also passthrough newsegment
events in TIME format (from the chain function) instead of creation a new
event. This is necessary to preserve the sequence number and the marker hack
used by subtitleoverlay

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list