[Bug 638168] textoverlay: don't return wrong-state when stopping while in text chain

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Mon May 14 07:37:26 PDT 2012


https://bugzilla.gnome.org/show_bug.cgi?id=638168
  GStreamer | gst-plugins-base | unspecified

--- Comment #26 from Andre Moreira Magalhaes <andrunko at gmail.com> 2012-05-14 14:37:24 UTC ---
(In reply to comment #23)
> Review of attachment 213880 [details]:
> 
> ::: gst/playback/gstplaysink.c
> @@ +1863,3 @@
> +    playsink->text_flush = FALSE;
> +    GST_PLAY_SINK_UNLOCK (playsink);
> +    gst_pad_send_event (pad, gst_event_new_flush_stop ());
> 
> This might cause problems if the flush-stop event reaches the other side of the
> subtitleoverlay, due to resetting the segments and other state. This doesn't
> happen here?
I added a patch at comment #25 that attempts to fix this.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list