[Bug 638168] textoverlay: don't return wrong-state when stopping while in text chain

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=638168
  GStreamer | gst-plugins-base | unspecified

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #214010|none                        |reviewed
             status|                            |

--- Comment #31 from Sebastian Dröge <slomo at circular-chaos.org> 2012-05-15 07:14:45 UTC ---
Review of attachment 214010:
 --> (https://bugzilla.gnome.org/review?bug=638168&attachment=214010)

::: gst/playback/gstplaysink.c
@@ +633,3 @@
+
+  _playsink_reset_segment_event_marker_id =
+      g_quark_from_static_string ("gst-playsink-reset-segment-event-marker");

Please do this in class_init, only has to be done once

@@ +1895,3 @@
+    if (format != GST_FORMAT_TIME) {
+      GST_ERROR_OBJECT (pad, "Newsegment event in non-time format: %s",
+          gst_format_get_name (format));

You should not ignore non-TIME segments here but just handle all formats
equally

@@ +1933,3 @@
+
+    /* make queue drop all cached data.
+     * This event will be dropped inside subtitleoverlay. */

I think it would be cleaner to send the event from outside subtitleoverlay and
also drop them from outside subtitleoverlay. This way we now have a quite
weird, asymmetric interaction between playsink and subtitleoverlay. Letting it
go through subtitleoverlay has no negative side effects because we update the
segments afterwards again.  (also, isn't subtitleoverlay flushing itself
anyway?)

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.