[Bug 674921] alsasink: use the iec958 payloader to support non-payloaded input streams

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Tue May 15 10:39:22 PDT 2012


https://bugzilla.gnome.org/show_bug.cgi?id=674921
  GStreamer | gst-plugins-base | 0.10.x

--- Comment #6 from Andoni Morales <ylatuya at gmail.com> 2012-05-15 17:39:19 UTC ---
Created an attachment (id=214137)
 View: https://bugzilla.gnome.org/attachment.cgi?id=214137
 Review: https://bugzilla.gnome.org/review?bug=674921&attachment=214137

alsasink: only check for spdif support in the selected device

The first issue is that in prepare, it was checking for "spec->format ==
GST_IEC958" instead of "alsa->iec958" and that's why the payloaded stream was
pushed to the PCM device instead of the iec958 one.

But with this fix, if the device supports digital output the sink will always
negotiate inside playbin an encoded format (ac-3, dts or mp3 instead of the raw
decoded one) and therefore always using the iec958 device which I don't think
that's what we want.
So I have also changed the probe function to use the device passed in the
'device' property, this way only when device=iec958 is set the pass-through
caps will be added to the supported caps.

I'm not sure if explained my self correctly and even if it's the correct
solution :)

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list