[Bug 676134] New: rtpjpegpay doesn't handle MJPG from Logitech C-920 camera

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=676134
  GStreamer | gst-plugins-good | git

           Summary: rtpjpegpay doesn't handle MJPG from Logitech C-920
                    camera
    Classification: Platform
           Product: GStreamer
           Version: git
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: gst-plugins-good
        AssignedTo: gstreamer-bugs at lists.freedesktop.org
        ReportedBy: youness.alaoui at collabora.co.uk
         QAContact: gstreamer-bugs at lists.freedesktop.org
                CC: rob.krakora at messagenetsystems.com
     GNOME version: ---


Created an attachment (id=214163)
 View: https://bugzilla.gnome.org/attachment.cgi?id=214163
 Review: https://bugzilla.gnome.org/review?bug=676134&attachment=214163

rtpjpegpay patch

The rtpjpegpay doesn't handle MJPG frames from the Logitech C-920 camera,
complaining about "error: Invalid component", the code that complains is the
one that reads the SOF header and checks that component 1 and 2 have the same
quantization table. The RFC says that the components must use the same quant
table :
http://www.rfc-editor.org/rfc/rfc2435.txt
section 3.1.8 (page 6) says :
   When table data is included, the number of tables present depends on
   the JPEG type field.  For example, type 0 uses two tables (one for
   the luminance component and one shared by the chrominance
   components).

The MJPG from the C920 uses a different quant table for each component, but in
the DQT marker, the quant tables for component 1 and 2 (the ones used by U and
V components) are exactly the same...

I've written a patch that fixes support for the C920 camera by checking if both
tables for U and V components are the same, if they are, it allows it and uses
the same table for both, if not, then it would give that error about components
being invalid.
Patch is attached and available in my repo (in branches rtpjpegpay-0.10 and
rtpjpegpay)
http://cgit.collabora.com/git/user/kakaroto/gst-plugins-good.git/commit/?h=rtpjpegpay-0.10&id=b15ba7fb54d3d9512edc07070c3a0438837a108f

Thanks.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.