[Bug 638168] textoverlay: don't return wrong-state when stopping while in text chain

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Wed May 16 06:47:41 PDT 2012


https://bugzilla.gnome.org/show_bug.cgi?id=638168
  GStreamer | gst-plugins-base | unspecified

Andre Moreira Magalhaes <andrunko> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #213880|0                           |1
        is obsolete|                            |
 Attachment #214151|0                           |1
        is obsolete|                            |

--- Comment #40 from Andre Moreira Magalhaes <andrunko at gmail.com> 2012-05-16 13:47:38 UTC ---
Created an attachment (id=214180)
 View: https://bugzilla.gnome.org/attachment.cgi?id=214180
 Review: https://bugzilla.gnome.org/review?bug=638168&attachment=214180

gstplaysink: Properly reset chain when receiving a custom flush event. 

(In reply to comment #39)
> Review of attachment 214151 [details]:
> 
> Looks good but:
> 
> ::: gst/playback/gstplaysink.c
> @@ +226,1 @@
>    gboolean text_flush;
> 
> This depends on the previous patch in attachment #213880 [details]? Could you merge the
> two patches?
Thanks for the review. Attaching the new merged patch.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list