[Bug 676647] New: Opus RTP payloader is leaking memory (patch included)

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=676647
  GStreamer | gst-plugins-bad | 0.10.36

           Summary: Opus RTP payloader is leaking memory (patch included)
    Classification: Platform
           Product: GStreamer
           Version: 0.10.36
        OS/Version: All
            Status: UNCONFIRMED
          Severity: major
          Priority: Normal
         Component: gst-plugins-bad
        AssignedTo: gstreamer-bugs at lists.freedesktop.org
        ReportedBy: dv at pseudoterminal.org
         QAContact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---


Created an attachment (id=214776)
 View: https://bugzilla.gnome.org/attachment.cgi?id=214776
 Review: https://bugzilla.gnome.org/review?bug=676647&attachment=214776

Linear increase in heap usage observed while using the payloader; patch
included

Using the Opus RTP payloader causes memory leaks.
The following command will show a linear increase in heap usage:

   gst-launch audiotestsrc ! opusenc ! rtpopuspay ! fakesink

while this one doesn't:

   gst-launch audiotestsrc ! opusenc ! fakesink

The heap increase has been confirmed both with the top command and with
valgrind massif.

The cause is a missing unref in the payloader's handle_buffer() function. The
buffer passed to it as an argument is not unreferenced.

The attached patch fixes this. It calls gst_buffer_unref(buffer); right before
the return line.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.