[Bug 676824] New: gst-rtsp-server is not compiled with warnings enabled...

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Fri May 25 08:05:59 PDT 2012


https://bugzilla.gnome.org/show_bug.cgi?id=676824
  GStreamer | gst-rtsp-server | git

           Summary: gst-rtsp-server is not compiled with warnings
                    enabled...
    Classification: Platform
           Product: GStreamer
           Version: git
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: gst-rtsp-server
        AssignedTo: gstreamer-bugs at lists.freedesktop.org
        ReportedBy: sebras at hotmail.com
         QAContact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---


When comparing gst-rtsp-server/configure.ac with those of
gst-plugins-* it is evident that GST_OPTION_CFLAGS is
missing WARNING_CFLAGS. The first patch adds this flag.

However, if gstreamer and gst-plugins-base are now built
with --disable-gst-debug we will get errors when compiling
gst-rtsp-server since warnings for unused variables are now
always enabled:

make[2]: Entering directory
`/home/sebrn/src/upstream/gst-rtsp-server/gst/rtsp-server'
  CC     libgstrtspserver_1.0_la-rtsp-client.lo
rtsp-client.c: In function ‘error’:
rtsp-client.c:1685:18: error: unused variable ‘client’
[-Werror=unused-variable]
rtsp-client.c: In function ‘error_full’:
rtsp-client.c:1699:18: error: unused variable ‘client’
[-Werror=unused-variable]
rtsp-client.c: In function ‘gst_rtsp_client_accept’:
rtsp-client.c:1895:15: error: variable ‘url’ set but not used
[-Werror=unused-but-set-variable]
cc1: all warnings being treated as errors

The second patch adds a check to gst-rtsp-server/configure.ac
that tests whether gstreamer had --disable-gst-debug set or
not. This is done in the same way as for gst-plugins-*.

Now gst-rtsp-server itself builds properly, but we get new
errors when doing the introspection:

make[3]: Entering directory
`/home/sebrn/src/upstream/gst-rtsp-server/docs/libs'
  DOC   Scanning header files
  DOC   Introspecting gobjects
gst-rtsp-server-scan.c: In function ‘get_object_types’:
gst-rtsp-server-scan.c:19:5: error: implicit declaration of function
‘gst_rtsp_auth_get_type’ [-Werror=implicit-function-declaration]
gst-rtsp-server-scan.c:20:5: error: implicit declaration of function
‘gst_rtsp_media_mapping_get_type’ [-Werror=implicit-function-declaration]
gst-rtsp-server-scan.c:21:5: error: implicit declaration of function
‘gst_rtsp_media_factory_get_type’ [-Werror=implicit-function-declaration]
gst-rtsp-server-scan.c:22:5: error: implicit declaration of function
‘gst_rtsp_media_get_type’ [-Werror=implicit-function-declaration]
gst-rtsp-server-scan.c:23:5: error: implicit declaration of function
‘gst_rtsp_server_get_type’ [-Werror=implicit-function-declaration]
gst-rtsp-server-scan.c:24:5: error: implicit declaration of function
‘gst_rtsp_session_pool_get_type’ [-Werror=implicit-function-declaration]
gst-rtsp-server-scan.c:25:5: error: implicit declaration of function
‘gst_rtsp_session_get_type’ [-Werror=implicit-function-declaration]
gst-rtsp-server-scan.c:26:5: error: implicit declaration of function
‘gst_rtsp_client_get_type’ [-Werror=implicit-function-declaration]
cc1: all warnings being treated as errors
Compilation of scanner failed: 
make[3]: *** [scan-build.stamp] Error 1

The third and final patch includes the proper header files
to the documentation files so as to make these compile. I
did this in the same way that inclusions have been done in
gst-plugins-base/docs/libs/gst-plugins-base-libs.types.

After applying this patch series gst-rtsp-server compiles
with compiler warnings enabled, regardless of whether 
gstreamer was compiled with --disabled-gst-debug or not.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list