[Bug 676739] Make stream changes using input-selector/playbin2 instantaneous

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=676739
  GStreamer | gst-plugins-base | unspecified

--- Comment #9 from Andre Moreira Magalhaes <andrunko at gmail.com> 2012-05-28 12:02:12 UTC ---
(In reply to comment #6)
> Review of attachment 214960 [details]:
> 
> ::: gst/playback/gstplaysink.c
> @@ +1902,3 @@
> +
> +    custom_flush = g_strdup_printf ("custom-%s-flush", sink_type);
> +    custom_flush_finish = g_strdup_printf ("custom-%s-flush-finish",
> sink_type);
> 
> Maybe just hardcode the three different names here instead of doing the dynamic
> string dance :)
> I would suggest prefixing the event names with playsink as it's now playsink
> API.
I prefer not to tbh, that would make 6 different variables and I don't want to
check for text-flush on audio/video events, etc. I left the names without a
prefix because they are also used in subtitleoverlay (custom-text-flush only),
but I can change if you prefer

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.